Sidebar implementation causes plugin incompatibility on WordPress/WooCommerce

batonac
7 Posts
batonac posted this 09 August 2017

I'm trying to use the YITH Ajax Product Filter on my WooCommerce site developed with Themler. Unfortunately the ajax widget just disappears when any filters are activated. As per the plugin developer's documentation, the problem commonly occurs when a sidebar is registered incorrectly as per the official WordPress standards:

(From [https://support.yithemes.com/hc/en-us/articles/231922648][1]):
Many users complain that they do not see the filter or reset the widget
list is not updated, the problem in most cases is this:

The problem is in the before_widget arg in register sidebar settings.
The correct way to register a sidebar is: 'before_widget' => '<li id class>', with id and class params, like you read in the WordPress Codex . Your theme use only classes and not the id.. Please, look here:
> https://codex.wordpress.org/Function_Reference/register_sidebar
>
> That amends must do the theme developer otherwise the first update will lose all changes.

Please change the way this code is rendered to fix this problem. Thanks!

[1]: https://support.yithemes.com/hc/en-us/articles/231922648 "YITH Support"

I'm trying to use the YITH Ajax Product Filter on my WooCommerce site developed with Themler. Unfortunately the ajax widget just disappears when any filters are activated. As per the plugin developer's documentation, the problem commonly occurs when a sidebar is registered incorrectly as per the official WordPress standards: > (From [https://support.yithemes.com/hc/en-us/articles/231922648][1]): > Many users complain that they do not see the filter or reset the widget > list is not updated, the problem in most cases is this: > > The problem is in the before_widget arg in register sidebar settings. > The correct way to register a sidebar is: `'before_widget' => '<li id class>'`, with id and class params, like you read in the WordPress Codex . Your theme use only classes and not the id.. Please, look here: > https://codex.wordpress.org/Function_Reference/register_sidebar > > That amends must do the theme developer otherwise the first update will lose all changes. Please change the way this code is rendered to fix this problem. Thanks! [1]: https://support.yithemes.com/hc/en-us/articles/231922648 "YITH Support"

Last edited 09 August 2017 by batonac

Vote to pay developers attention to this features or issue.
7 Comments
Order By: Standard | Newest
Support Team
Support Team posted this 10 August 2017

Hi,

Themler theme is a little different then default WP themes due to many reasons. For example, Themler displays widgets as DIVs, not a list items. It allows you to style widgets in Themler in the way you need. Therefore if some WP plugin is harcoded to work with some specific structure of the page elements it may not work with Themler themes.
I've asked our developers if there is a way to fix the reported issue with this plugin. We'll let you know when we receive any news from them.

Thank you,
Olivia

Hi, Themler theme is a little different then default WP themes due to many reasons. For example, Themler displays widgets as DIVs, not a list items. It allows you to style widgets in Themler in the way you need. Therefore if some WP plugin is harcoded to work with some specific structure of the page elements it may not work with Themler themes. I've asked our developers if there is a way to fix the reported issue with this plugin. We'll let you know when we receive any news from them. Thank you, Olivia
batonac
7 Posts
batonac posted this 29 August 2017

Hello,

Any updates here? This Woocommerce functionality is significant for my use case and it would be much appreciated to see this code brought up to spec.

I submitted a ticket to the widget developer who gave this response:

The problem is that the theme author created the sidebar without the ID. I’m sorry but it’s not possible for me to change this because I would need to edit some theme files. You can ask the theme author to change this.

It appears from his response that a resolution would be a simply as including "the ID" when creating the widget, which feels really rudimentary, and not related to displaying in DIVs or list items.

Since I'm not asking for a change in functionality, only for fixing compatibility related to official specifications, could you forward this to the developers as a bug report?

Thanks

Hello, Any updates here? This Woocommerce functionality is significant for my use case and it would be much appreciated to see this code brought up to spec. I submitted a ticket to the widget developer who gave this response: > The problem is that the theme author created the sidebar without the ID. I’m sorry but it’s not possible for me to change this because I would need to edit some theme files. You can ask the theme author to change this. It appears from his response that a resolution would be a simply as including "the ID" when creating the widget, which feels really rudimentary, and not related to displaying in DIVs or list items. Since I'm not asking for a change in functionality, only for fixing compatibility related to official specifications, could you forward this to the developers as a bug report? Thanks
Support Team
Support Team posted this 31 August 2017

Hi,

Our developers added ID field. The fix will be available in the next Themler update.

Thank you,
Olivia

Hi, Our developers added ID field. The fix will be available in the next Themler update. Thank you, Olivia
tmgarrison
42 Posts
tmgarrison posted this 05 September 2017

Hi Olivia,
I'd like to put my 2-cents worth in here, as this seems to be the most relevant thread.

My footer is supposed to be...in the footer.
Instead, it appears to the right of the content area on all pages except the home page. The footer "was" positioned correctly until I updated Themler today.

I don't have any custom code nor do I have any additional software installed.

The home page is fine. But internal pages have the footer to the right of the content area, and to the right of the "aside" which is part of the sidebar area.
I know that it's a div tag that was "not" closed where it should have been closed, and that the footer is "inside" the div tag for the sidebar login. I "could" dig into the mess, but it would seem this could happen often. I find it hard to believe that it's only "my" installation that's effected.

After checking other pages, the same abnormality happens where the footer is to the right of the content area. But it seems the "aside" tag is coded properly on other pages. I was only able to spot the div problem in the one page. Yet, all pages except the home page have the footer off to the right...trying to make a new home.

I didn't touch the template after the update of Themler. In fact, I haven't touched anything in this particular project for a while due to being overly busy. The first thing I did when I logged in to Themler was to update. I inspected the pages and found there is at least the 1 coding error.
Any thoughts?

The "default" portion of the template seems to be arranged correctly. It's the "page" part of the template that is problematic. I'm going to do some experimenting and see if I can find the issue.

I haven't attempted to make any changes to the width or any other setting. Simply updated Themler and the footer became part of the content area. This is a personal project in a sub-directory, so I'm under no pressure to make a fix. But I would like to see the footer...in the footer.

Hi Olivia, I'd like to put my 2-cents worth in here, as this seems to be the most relevant thread. My footer is supposed to be...in the footer. Instead, it appears to the right of the content area on all pages except the home page. The footer "was" positioned correctly until I updated Themler today. I don't have any custom code nor do I have any additional software installed. The home page is fine. But internal pages have the footer to the right of the content area, and to the right of the "aside" which is part of the sidebar area. I know that it's a div tag that was "not" closed where it should have been closed, and that the footer is "inside" the div tag for the sidebar login. I "could" dig into the mess, but it would seem this could happen often. I find it hard to believe that it's only "my" installation that's effected. After checking other pages, the same abnormality happens where the footer is to the right of the content area. But it seems the "aside" tag is coded properly on other pages. I was only able to spot the div problem in the one page. Yet, all pages except the home page have the footer off to the right...trying to make a new home. I didn't touch the template after the update of Themler. In fact, I haven't touched anything in this particular project for a while due to being overly busy. The first thing I did when I logged in to Themler was to update. I inspected the pages and found there is at least the 1 coding error. Any thoughts? The "default" portion of the template seems to be arranged correctly. It's the "page" part of the template that is problematic. I'm going to do some experimenting and see if I can find the issue. I haven't attempted to make any changes to the width or any other setting. Simply updated Themler and the footer became part of the content area. This is a personal project in a sub-directory, so I'm under no pressure to make a fix. But I would like to see the footer...in the footer.

Last edited 05 September 2017 by tmgarrison

batonac
7 Posts
batonac posted this 06 September 2017

Hi,

Our developers added ID field. The fix will be available in the next Themler update.

Thank you,
Olivia

Thank-you Olivia!!!

> Hi, > > Our developers added ID field. The fix will be available in the next Themler update. > > Thank you, > Olivia Thank-you Olivia!!!
batonac
7 Posts
batonac posted this 06 September 2017

Hi Olivia,
I'd like to put my 2-cents worth in here, as this seems to be the most relevant thread.

I'm sorry that you're having this problem, but I think you should start a new thread since this is actually a completely different issue than what I'm dealing with here...

> Hi Olivia, > I'd like to put my 2-cents worth in here, as this seems to be the most relevant thread. I'm sorry that you're having this problem, but I think you should start a new thread since this is actually a completely different issue than what I'm dealing with here...
Support Team
Support Team posted this 06 September 2017

tmgarrison,

Could you please create a new private or public topic with the provided issue description. The original issue reported in this topic is completely different and it'e better to mix mix different issues in one topic.

Thank you,
Olivia

tmgarrison, Could you please create a new private or public topic with the provided issue description. The original issue reported in this topic is completely different and it'e better to mix mix different issues in one topic. Thank you, Olivia
You must log in or register to leave comments