CSS Issue

bsjelin
45 Posts
bsjelin posted this 16 January 2017

Hello - I had some issues with applying a plugin and this is what they were able to find as an issue with the css file of the template. Is this something that can be fixed?

Hello Brandon,

It seems there are some CSS parsing errors in the
/templates/timeless_v1/css/bootstrap.min.css?version=1.0.481 file. I
think it has something to do with the following code:
input[type=radio]{margin:4px 0 0;margin-top:1px\9;line-height:normal}

The part '1px\9' seems to be invalid and messing up the file when it
is minified and combined by the plugin. Excluding this file have
resolved this issue somewhat but I'd recommend fixing the error first
so the file can be included before using the Optimize CSS Delivery
feature. It sometimes doesn't work well when files are excluded.

I used http://csslint.net/ to help find the error.

Hello - I had some issues with applying a plugin and this is what they were able to find as an issue with the css file of the template. Is this something that can be fixed? > Hello Brandon, > > It seems there are some CSS parsing errors in the > /templates/timeless_v1/css/bootstrap.min.css?version=1.0.481 file. I > think it has something to do with the following code: > input[type=radio]{margin:4px 0 0;margin-top:1px\9;line-height:normal} > > The part '1px\9' seems to be invalid and messing up the file when it > is minified and combined by the plugin. Excluding this file have > resolved this issue somewhat but I'd recommend fixing the error first > so the file can be included before using the Optimize CSS Delivery > feature. It sometimes doesn't work well when files are excluded. > > I used http://csslint.net/ to help find the error.
Vote to pay developers attention to this features or issue.
2 Comments
Order By: Standard | Newest
Support Team
Support Team posted this 18 January 2017

Hi,

Themler uses Bootstrap framework and this line of code is provided by this framework. You can find it in bootstrap.min.css on http://getbootstrap.com/ too. This plugin will have problems with any bootstrap theme.

Thank you,
Olivia

Hi, Themler uses Bootstrap framework and this line of code is provided by this framework. You can find it in bootstrap.min.css on http://getbootstrap.com/ too. This plugin will have problems with any bootstrap theme. Thank you, Olivia
bsjelin
45 Posts
bsjelin posted this 24 January 2017

Here is the next response from the developer.

The error in the file needs to be corrected. That's the only thing
that can work. Otherwise you will have to keep it excluded. View the
error that I pointed out to you: input[type=radio]{margin:4px 0
0;margin-top:1px\9;line-height:normal}

There ought to be a space between the 1px and the \9. This is a
parsing error and will cause issues based on how the css parser
processes errors. You may find more on that here:
https://www.w3.org/TR/css-syntax-3/#error-handling. This is especially
unforgiving when the CSS files are minified.

The theme on this website also uses bootstrap and considering the
popularity of bootstrap themes today if the problem was with bootstrap
that would be a major problem with this plugin. This is not the case.
I can only recall you with this problem.

Take a look at the original bootstrap file here:
https://maxcdn.bootstrapcdn.com/bootstrap/3.1.1/css/bootstrap.min.css.
Do a text search for \9 and you will see there's always a space
occurring before it. Perhaps the theme developer used a substandard
minification library to minify the CSS file, which has removed the
space. You will note that the original bootstrap file from maxcdn is
already minified but still retains the space.

If your theme has any CSS minification feature enabled try to disable
it and only allow JCH Optimize to handle the minification of your
files. Otherwise you can explore somehow using the original bootstrap
file in place of the one distributed with the theme if the developer
refuses to clean up his work.

Here is the next response from the developer. > The error in the file needs to be corrected. That's the only thing > that can work. Otherwise you will have to keep it excluded. View the > error that I pointed out to you: input[type=radio]{margin:4px 0 > 0;margin-top:1px\9;line-height:normal} > > There ought to be a space between the 1px and the \9. This is a > parsing error and will cause issues based on how the css parser > processes errors. You may find more on that here: > https://www.w3.org/TR/css-syntax-3/#error-handling. This is especially > unforgiving when the CSS files are minified. > > The theme on this website also uses bootstrap and considering the > popularity of bootstrap themes today if the problem was with bootstrap > that would be a major problem with this plugin. This is not the case. > I can only recall you with this problem. > > Take a look at the original bootstrap file here: > https://maxcdn.bootstrapcdn.com/bootstrap/3.1.1/css/bootstrap.min.css. > Do a text search for \9 and you will see there's always a space > occurring before it. Perhaps the theme developer used a substandard > minification library to minify the CSS file, which has removed the > space. You will note that the original bootstrap file from maxcdn is > already minified but still retains the space. > > If your theme has any CSS minification feature enabled try to disable > it and only allow JCH Optimize to handle the minification of your > files. Otherwise you can explore somehow using the original bootstrap > file in place of the one distributed with the theme if the developer > refuses to clean up his work.
You must log in or register to leave comments